Trenger ikke å logge 4XX-feil som warning - dette er oftest brukerfei… #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l i en eller annen kontekst. 5XX-feil kan fint logges som warning
charliemidtlyng
requested review from
stigebil,
kristeine,
halvorbmundal,
idaame,
ViktorGSolberg,
olekvernberg,
MagnusTonnessen,
ma10s,
throndi,
bragejahren,
UyQuangNguyen and
gunnsteingarmo
stigebil
approved these changes
Jun 24, 2024
throndi
approved these changes
Jun 24, 2024
|
Kan evt være API som returnerer 404 hvis man ikke finner f.eks. journalpost. Som kanskje blir litt vanskeligere å identifisere hvis man logger info |
Forsåvidt sant, men nå har dere en app som logger 404-warning hver halvtime, men utover dét har det ikke vært noe fornuftig 404 på laaaaang tid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l i en eller annen kontekst. 5XX-feil kan fint logges som warning.
Som vakt opplever jeg mye unødig støy rundt 400-feil fordi folk gjør søk i løsningen med input som enten ikke er gyldig, eller personer som ikke finnes i EF.
Ellers er det fair å logge 5XX-requestene som warning.
Hva tenker dere på BAKS?